Repository navigation
Conversation
Use the mode prefix for keycaps and only strip it from translated labels when present. This preserves Chinese thumbnail labels without a prefix. prompt: 这里乱码了，尝试修复
Author
|
ps: i love this pdf reader so much! Especially for big pdfs.I am sorry to use gpt for this pr, but hope it can locate and (probable) fix the problem correctly. -ur sincerely K.C |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Simplified Chinese translation of
& Thumbnailsis缩略图, without the&prefix. Both palette renderers take the first byte as a keycap and skip two bytes for the label, splitting the first UTF-8 character and displaying replacement characters (�/�略图).Use the actual mode prefix for keycaps and a shared helper that strips a prefix only when present. Apply this to the original and ng palettes. Add 10 regression cases covering Chinese labels with and without prefixes, English, trailing access-key text, and empty/short labels.
Validation: compiled and ran the extracted C++ helper, repository string-trimming functions, and new regression cases in an isolated WebAssembly harness: 10/10 pass; the old two-byte slicing fails 6/10. clang-format and
git diff --checkpass. Full application build, integrated unit-test runner, and GUI verification were not run because this machine lacks the Visual Studio C++ toolchain.