Repository navigation
Conversation
… views by registry entries - A lockfile-maintenance planning error fails only its repository (StepFailure::Repo), not the whole batch; only cache errors stay run-level. prs.branch is capped at 200 characters at load, derived from the shared 240-character branch limit and the room fixed labels need. - Obsolete-PR closure and branch cleanup decide on one degraded flag, read when the lifecycle is prepared, so lockfile tool warnings no longer turn cleanup off while obsolete PRs still close. - Catalog views are keyed by a digest of every operator registry entry's scope, so adding, removing or rotating an entry misses old views. - Catalog views are saved borrowed and in one transaction; unchanged branch and lookup hints are not rewritten. - The lockfile-maintenance PR body no longer opens with an empty table. - Branch labels still shared after the manager prefix (case or punctuation differences) take a short stable hash of the branch identity instead of failing the repository with BranchCollision.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
count-patchula | b5e07a4 | Commit Preview URL Branch Preview URL |
Nov 15 2026, 11:09 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six fixes from the engine/update scan.
Fixes
Write::maintenanceturned aPlanErrorinto the run-levelError::Invalid, so one repository's config (say a 225-characterprs.branchwith no updates) failed the whole batch: every repository's report row, schedule turn and public record was dropped and the server backed them all off. It now returnsStepFailure::Repo, asplans()does. Only the cache error fromdefer_completed_refreshstays run-level.prs.branchis also capped at load.patchula_confignow holdsMAX_BRANCH_LEN(240, whichbranch_nameuses),BRANCH_LABEL_ROOM(40) andMAX_BRANCH_PREFIX_LEN(200). A compile-time assert inplan.rschecks that the longest fixed label (lock-file-maintenance) plus a collision suffix fits in that room.repo.degraded()before lockfile generation, and cleanup read it after, so a lockfile tool's warning skipped cleanup while obsolete PRs still closed, and stale branches piled up.Lifecyclenow readsdegradedonce, when it is prepared. Obsolete closure uses that value, and the engine's cleanup readsLifecycle::degraded()instead of the repository's warnings at cleanup time.CatalogScopenow carries a digest of every operator entry'sscope(), computed once per engine. Adding, removing or rotating an entry misses every view read before, as the HTTP cache key does. I keyed by the whole entry set, not "the matching entry": a catalog can be built from several reads, including mirror redirects, so its matching entry can't be known before the fetch. Keying by all entries is a superset and fails closed. The cost is one catalog refetch whenever any entry changes.Savedholds aCow<Catalog>, so saving borrows the fetched catalog instead of deep-cloning it. Views are written through a newCache::set_states: one writer round trip, one transaction.BranchHintandLookupHintare no longer rewritten when they equal what was read.github.com/Sirupsen/logrusandgithub.com/sirupsen/logrusin twogo.modfiles, groupsLintersandlinters) each take-<first 8 hex of sha256(branch identity)>. The identity depends only on the dependency or group, so names stay the same from run to run and in any order.BranchCollisionnow only covers a hash collision, and its text no longer suggests explicit groups.State versions:
extract/files12,config/config-files9,catalog/catalog-controls10, with their rows updated intests/state-versions.tsv.Docs:
guide/pull-requests.md(collision hash, the 200-character prefix cap, which warnings skip cleanup and obsolete closure),internals/cache.md(the catalog scope), and a schema doc line onprs.branch.Tests
engine/tests/write.rsan_unnameable_maintenance_branch_fails_only_its_repository: a 225-character prefix with no updates. The run returnsOkand only the repository fails.config/tests/config.rsa_branch_prefix_longer_than_the_cap_is_refused_at_load.update/tests/write.rswarnings_after_preparation_leave_the_lifecycle_undegraded. Also,lookup_warnings_defer_obsolete_pr_closurenow assertsdegraded().engine/src/catalogs/tests.rsregistry_entries_key_the_views_they_may_have_read: same entry reused; a rotated or removed entry misses.update/src/pr/body/tests.rsthe_maintenance_body_has_no_empty_update_table.update/src/plan/planning.rsnames_that_differ_only_in_case_or_punctuation_take_a_stable_hash: the go.mod and group cases, checked stable across runs and input order.actions_lock_maintenance_commits_only_the_lockwas re-recorded because its PR body lost the empty table.Ran on the VM: tests for config, cache, update, engine, cli and server, the manager and lookup corpus tests, and clippy
-D warningson the changed crates.Follow-ups
matchonLifecycle::degraded().policy_allowsstill readsrepo.degraded()after lockfile generation, so a lockfile warning still blocks auto-merge. That is deliberately conservative and unchanged here.