Repository navigation
Conversation
…oups, install proof - Yarn reads every .yarnrc.yml from its project up to the filesystem root; each one up to the tree root is now sanitized for the run and restored by a drop guard, as every .npmrc already was. - mise lock runs with the asdf and vfox backends disabled and checks every tool argument it locks, options included, with the lookup's name, option and instance-metadata checks (patchula_mise::admit) before mise starts. - The executor kills the process group whenever the leader exits, and from a drop guard on cancellation, so grandchildren never outlive the call or hold its pipes; dotnet runs with MSBUILDDISABLENODEREUSE=1. - A first use installs its tools with `mise install` apart from the run and records the install when mise succeeds, so a failing tool no longer gets its toolchain uninstalled and reinstalled on the next call. - Bump the extract, files, config, config-files, catalog and catalog-controls state versions for the crates/mise/src edits.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
count-patchula | c459c67 | Commit Preview URL Branch Preview URL |
Nov 15 2026, 11:21 PM |
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes from the tools/process scan.
1. Yarn reads parent
.yarnrc.ymlfilesYarn Berry reads every
.yarnrc.ymlfrom its working directory up to the filesystem root, but only<cwd>/.yarnrc.ymlwas cleaned ofplugins/yarnPath. A root.yarnrc.ymlwithplugins: [{path: evil/yarn.lock}]would load repository JavaScript into a Berry project inapp/.Now every
.yarnrc.ymlfrom the project up to the tree root is replaced by its sanitized copy for the run. A newcontext::Replacedguard restores the committed files on the normal path and on drop, so an early return or a cancelled run restores them too. The.npmrchandling now uses the same guard.Test:
yarn_sees_every_yarnrc_up_to_the_tree_root_sanitised(success and failure) checks that the tool sees only sanitized copies at both levels and that both committed files come back.2.
mise lockran plugin backends and skipped the lookup checksmise lock(Run::Mise, the one run that reads the repository's tool configuration) now always runs withMISE_DISABLE_BACKENDS=asdf,vfox, throughpatchula_mise::without_plugins, which lookups use too.mise.tomlis written, every tool argument it locks goes through the newpatchula_mise::admit. That is the name and option check plus the instance-metadata guard, built from the entry's options withbracketed, as a lookup builds them. Lookups now go throughadmitas well, so both paths share one entry point.vfox:jdx/vfox-yarnfirst foryarnandvfox:jdx/vfox-poetryfirst forpoetry. With plugins disabled for the Count's own tool runs, the real Yarn test failed: the store's install is recorded as a vfox one. Those plugins are chosen by mise's registry for tools the Count names, not by a repository, so the threat model does not require it. The restriction applies to every mise that handles repository-chosen tool names: lookups andmise lock.mise lockrecordsyarnasaqua:yarnpkg/berryandpoetryaspypi:poetry, the next backends. This is documented in guide/lockfiles.md.Tests:
mise_lock_refuses_tools_a_lookup_would_refusecoversasdf:/vfox:names and metadata URLs in a string, an inline table, an array of tables and a[tools.x]table. The run fails andmise locknever starts.MiseFixturenow checks that everymise lockrun has the backends disabled.3. Process groups only died on timeout
patchula-processnow kills the leader's process group every time the leader exits, whatever its exit status. AGroupdrop guard does the same on cancellation and timeout. Data already in the pipes survives the kill, so the drains still read everything the leader wrote. A grandchild that keeps stdout open can no longer turn a successful run intoTimedOut. dotnet runs withMSBUILDDISABLENODEREUSE=1.Tests (Linux):
a_grandchild_does_not_outlive_a_command_that_exits(exit 0 and exit 3;sleep 300 &holds stdout, which used to hang until the limit) anda_cancelled_command_takes_its_grandchildren_with_it.4. A failed tool run reinstalled its toolchain next time
A first use now runs
mise install <specs>on its own: clear and seed under the exclusive lock, then install under the shared lock with the 30-minute allowance. The install is recorded as soon as mise succeeds. The tool run itself always has the 180-second limit. A Rust install gets the sameRUSTUP_HOME/CARGO_HOMEas the run. A failing run, including the Go public-proxy attempt before its retry, keeps its install.Tests:
first_tool_use_installs_apart_from_the_run(whether the tool passes or fails, the second call neither uninstalls nor reinstalls) anda_rust_install_uses_the_runs_toolchain_homes.Other
crates/mise/src/is hashed by the engine'sextract,files,configandconfig-filesstates. Bumping those versions changescrates/engine/src/lib.rs, whichcatalogandcatalog-controlshash, so all six are bumped intests/state-versions.tsv.cargo testfor patchula-process, patchula-mise, patchula-tools (unit), patchula-datasource and patchula-notes;mise run test:tools(40 real tool tests); the enginestate_paritytest; clippy-D warningson process, mise, tools and engine.Follow-ups
yarnandpoetryto non-plugin backends, so no lockfile tool install runs a vfox plugin at all. That would mean new specs in defaults.toml and test:tools, a reinstall of existing stores, and real-tool checks.mise lock(withMISE_AUTO_INSTALL=true) ever installs a tool and so runs an option such aspostinstall. If it does, refuse those options formise lock.