SeeAnnotationToTestRule doesn't resolve imported class names

@see

We import our test classes and reference them by their short name:

use Acme\Tests\User\UserMailerTest;

/**
 * @see UserMailerTest
 */
final class UserMailer {}

This reports Class "Acme\User\UserMailer" is missing @see annotation with test case class reference. Writing @see \Acme\Tests\User\UserMailerTest passes, but php-cs-fixer's fully_qualified_strict_types with import_symbols shortens it again on the next run.

The rule hands the raw tag text to is_a(), so a short name never matches:

phpstan-rules/src/Rules/SeeAnnotationToTestRule.php

Lines 126 to 139 in 3e1ea6b

    
           private function hasSeeTestCaseAnnotation(array $seeTags): bool 
        
           { 
        
               foreach ($seeTags as $seeTag) { 
        
                   if (! $seeTag->value instanceof GenericTagValueNode) { 
        
                       continue; 
        
                   } 
        
                   if (is_a($seeTag->value->value, TestClassName::PHPUNIT_TEST_CASE, true)) { 
        
                       return true; 
        
                   } 
        
               } 
        
               return false; 
        
           }

Resolving it through the docblock's name scope first, e.g. with getNullableNameScope()->resolveStringName(), would fix it.

Rector's AddSeeTestAnnotationRector had the same problem (rectorphp/rector#9875), fixed in rectorphp/rector-phpunit#779.

Version: symplify/phpstan-rules 14.19.1

Thank you for your report!

We'll need an isolated failing demo link from: http://getrector.com/demo,
that way we can reproduce the bug.

This one is a PHPStan rule, so the Rector demo can't run it. The snippet above reproduces it with SeeAnnotationToTestRule enabled.

Ah, sorry, wrong repo. Can you send failing test PR with fixture then?

No worries! The failing fixture is up in #378.

Navigation Menu

Repository navigation

`SeeAnnotationToTestRule` doesn't resolve imported class names #377

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	private function hasSeeTestCaseAnnotation(array $seeTags): bool
	{
	foreach ($seeTags as $seeTag) {
	if (! $seeTag->value instanceof GenericTagValueNode) {
	continue;
	}

	if (is_a($seeTag->value->value, TestClassName::PHPUNIT_TEST_CASE, true)) {
	return true;
	}
	}

	return false;
	}

SeeAnnotationToTestRule doesn't resolve imported class names #377

Description

Activity

TomasVotruba commented on Oct 17, 2026

Brainshaker95 commented on Oct 18, 2026

TomasVotruba commented on Oct 18, 2026

Brainshaker95 commented on Oct 18, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`SeeAnnotationToTestRule` doesn't resolve imported class names #377