Repository navigation
Register LaravelPresenceResolver in services.neon - #383
Merged
TomasVotruba merged 1 commit intoOct 28, 2026
Merged
TomasVotruba merged 1 commit into
TomasVotruba merged 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TomasVotruba
enabled auto-merge (squash)
October 28, 2026 15:54
Member
|
Makes sense, thank you Simon 👍 |
TomasVotruba
disabled auto-merge
October 28, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaravelPresenceResolver(#331) is only registered inconfig/symfony-rules.neon, but several rules need it in their constructor, e.g.NoConstructorAndRequiredTogetherRule,NoListenerWithoutContractRule,NoServiceJugglingRuleandNoNullableServiceInConstructorRule.A project that registers rules one by one and includes only
config/services/services.neon(instead of the whole sets) fails with:Registering it in the project config is no workaround: it fails with "Multiple services of type ... found" once the service is in
services.neon.This PR moves the registration to
config/services/services.neon, next to the other shared services. Setups using the extension installer load both files, so nothing changes for them. A test checks thatservices.neonalone provides the service.ComposerRequireResolver(#380) insymfony-rules.neonis the same kind of case, but it's only used byCommandMustHaveAsCommandAttributeRuleand its test registers it with its ownworkingDirectory, so I left it out of this PR.🤖 Generated with Claude Code