Repository navigation
Separate random draws from review recommendations - #256
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Ericko00o
changed the title
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Check CONTRIBUTING.md carefully and enforce the rules. In particular, the manner for writing git commit messages.
ac3968c to
c06be4d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Before asking someone to review, you MUST resolve any regressions flagged by GitHub Actions. |
162d9ee to
e299d69
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
3752b2b to
a6dbeba
Compare
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Fold similar commits and refine git commit messages per CONTRIBUTING.md.
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Rebase latest main branch and resolve conflicts.
d6f4ca2 to
5a6dba5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Remove unnecessary Co-authored-by markers.
Avoid ambiguous Refs #210.
Do close an issue when you submit a pull request.
5a6dba5 to
120f239
Compare
120f239 to
aa1efee
Compare
Overdue reviews can monopolize explicit random selections and prevent other eligible problems from being offered. Give each problem matching the selected levels and topic an equal chance, avoiding the current problem when alternatives exist. Keep review priority for automatic recommendations and identify the randomly selected problem's level. Closes sysprog21#210
aa1efee to
0d0a265
Compare
Ericko00o
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thank @Ericko00o for contributing! |
3 participants
Explicit random selection can be monopolized by overdue reviews, leaving other eligible problems unreachable. Sample uniformly from the selected difficulty and topic pool when the candidate clicks Random, exclude the current problem when alternatives exist, and display the selected problem's difficulty. Automatic recommendations and filter changes retain their existing review policy.
Keep this PR limited to the picker policy and its regression tests. Cross-navigation draw persistence, storage tickets, URL identifiers, and report completion tracking are prepared separately and are not included here.
Validation: all 162 targeted picker and lobby tests passed with no failures or skips. ESLint, formatting, and staged checks passed. The full browser suite reported 1039 passed, 5 failed, and 3 skipped. The Git hooks suite passed all 46 checks. The full gate did not pass: fmt, clippy, and cargo-test require the missing Cargo toolchain; wire-fixtures and recording-provision-check-tests encounter existing Windows environment failures; browser-tests includes four Windows ESM path failures and one unavailable-server face-check failure. Java and two built-server browser cases were skipped, and cargo-audit, actionlint, ruff, and shellcheck were unavailable.
Closes #210