android: notify users before device key expiry - #875
Conversation
434d2b8 to
2e6671e
Compare
hiimtmac
left a comment
hiimtmac
left a comment
There was a problem hiding this comment.
Should an expiry change defensively cancel any notification that has already been posted? I think this handles canceling the "work to schedule a notification" but if you had a notification already posted, did the re-auth, the notification could still be visible even though its no longer relevant? (I could be wrong about this tho!)
We were surfacing expiry warnings in-app when a netmap update caused the warning state to be recalculated. This change schedules a system notification using WorkManager, and reschedules when the expiry or configured warning window changes. Updates tailscale/tailscale#20989 Signed-off-by: kari-ts <kari@tailscale.com>
2e6671e to
ddbd72e
Compare
yes, good catch! added a defensive cancelation |
We were surfacing expiry warnings in-app when a netmap update caused the warning state to be recalculated. This change schedules a system notification using WorkManager, and reschedules when the expiry or configured warning window changes. Updates tailscale/tailscale#20989 Signed-off-by: kari-ts <kari@tailscale.com> (cherry picked from commit 0841833)
2 participants
We were surfacing expiry warnings in-app when a netmap update caused the warning state to be recalculated. This change schedules a system notification using WorkManager, and reschedules when the expiry or configured warning window changes.
Updates tailscale/tailscale#20989