Skip to content

docs(agents): add non-obvious gotchas and bump go-colorable - #33

Merged
takecy merged 2 commits into
masterfrom
docs/agents-gotchas
Oct 7, 2026
Merged

takecy merged 2 commits into
masterfrom
docs/agents-gotchas

Conversation

@takecy

@takecy takecy commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Issue

  • なし(CLAUDE.md 監査に基づく改善)

Overview

ローカルの変更を 1 PR・2 コミットにまとめました。

docs(agents): AGENTS.md に自明でない注意点を追記

CLAUDE.md / .github/copilot-instructions.md は AGENTS.md への symlink のため、3 つすべてに反映されます。

  • syncer.execute の eg.Go は常に nil を返す(リポジトリ単位の失敗は runStats → exit 2、セットアップエラーのみ Run が error → exit 1)
  • このリポジトリは vendor 管理しない(make tidy は go mod tidy のみ)
  • syncer のテストは newSyncWithFake を使い、実 git テストは t.TempDir() の bare repo で外部非依存にする。os.Stdout を差し替えるテストは t.Parallel() 不可
  • master への push で tagging.yml が自動タグ付けし、merge commit 方式のためブランチ各コミットの type がバージョン上げ幅を決める(github-tag-action v5.5 の README で確認済み)

chore(deps): mattn/go-colorable を v0.1.16 に更新

  • 間接依存の更新のみ。make build / make test(-race)/ make lint がローカルで通過済み

挙動の変更はありません。

🤖 Generated with Claude Code

https://claude.ai/code/session_01GvvjLc6XrTE5wQpcMiGYiu

takecy and others added 2 commits October 7, 2026 13:15
…lease tagging

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GvvjLc6XrTE5wQpcMiGYiu
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GvvjLc6XrTE5wQpcMiGYiu
@takecy
takecy marked this pull request as ready for review October 7, 2026 04:19
Copilot AI balanced review requested due to automatic review settings October 7, 2026 04:19
@takecy
takecy merged commit 9b01224 into master Oct 7, 2026
2 checks passed
@takecy
takecy deleted the docs/agents-gotchas branch October 7, 2026 04:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The guidance matches repository behavior, the dependency files are consistent, and no blocking issues were identified.

Review effort: Balanced
Findings: None

What changed in this PR

Documents repository-specific development practices and updates an indirect dependency without changing application logic.

Changes:

  • Adds guidance on error handling, testing, dependency management, and release tagging.
  • Updates go-colorable to v0.1.16 with matching checksums.
File Description
go.sum Updates go-colorable checksums.
go.mod Bumps indirect go-colorable dependency to v0.1.16.
AGENTS.md Documents development and release gotchas.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants