Repository navigation
fix: process Firebase redirect result after Google login - #11
Open
tangentstorm wants to merge 1 commit into
Open
tangentstorm wants to merge 1 commit into
tangentstorm wants to merge 1 commit into
Conversation
signInWithRedirect navigates away, so getRedirectResult after it never ran. On return the page only checked currentUser(), leaving the redirect credential unconsumed and re-showing the login buttons (Fixes #10).
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getRedirectResult(auth)on login page load (via newprocessRedirectResult()) before checkingcurrentUser()/ showing buttonsgetRedirectResult+ success/fail handling aftersignInWithRedirectinattemptLogin()(that code never ran because redirect navigates away)Fixes #10
Test plan
tanco login→ Login with Google → complete Google UI → page should POST to/auth/successand CLI should receive JWT (not loop back to buttons)/login(no?pre=) after Google redirect should still complete and land on login success pathcurrentUser()without clicking buttons