Skip to content

🚚 Name executable document grids <Grid> and <Pane> (#781) #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taras merged 2 commits into from
Sep 10, 2026
Merged

🚚 Name executable document grids <Grid> and <Pane> (#781) #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfe4d0b
📝 Name interactive presentation as Grid and Pane (#781)
taras Sep 8, 2026
860448b
🚚 Rename the interactive presentation domain to Grid and Pane (#781)
taras Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/publish-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Validate the manifests declare this version
run: |
VERSION="${{ steps.resolve.outputs.value }}"
for f in packages/durable-streams/deno.json packages/runtime/deno.json packages/terminal/deno.json packages/core/deno.json packages/acp/deno.json packages/terminal-tmux/deno.json packages/testing/deno.json packages/test-agent/deno.json packages/web/deno.json packages/workflow/deno.json packages/cli/deno.json packages/code-review-agent/deno.json; do
for f in packages/durable-streams/deno.json packages/grid/deno.json packages/runtime/deno.json packages/core/deno.json packages/acp/deno.json packages/grid-tmux/deno.json packages/testing/deno.json packages/test-agent/deno.json packages/web/deno.json packages/workflow/deno.json packages/cli/deno.json packages/code-review-agent/deno.json; do
declared="$(jq -r .version "$f")"
if [ "$declared" != "$VERSION" ]; then
echo "::error::$f declares $declared, not $VERSION — the tag does not match the manifests"
Expand Down Expand Up @@ -68,39 +68,39 @@ jobs:
package: packages/durable-streams
version: ${{ needs.version.outputs.value }}

runtime:
needs: [version]
grid:
needs: [version, durable-streams]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/runtime
package: packages/grid
version: ${{ needs.version.outputs.value }}

terminal:
needs: [version, durable-streams]
runtime:
needs: [version]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/terminal
package: packages/runtime
version: ${{ needs.version.outputs.value }}

core:
needs: [version, durable-streams, runtime, terminal]
needs: [version, durable-streams, grid, runtime]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/core
version: ${{ needs.version.outputs.value }}

acp:
needs: [version, core, runtime, terminal]
needs: [version, core, grid, runtime]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/acp
version: ${{ needs.version.outputs.value }}

terminal-tmux:
needs: [version, terminal]
grid-tmux:
needs: [version, grid]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/terminal-tmux
package: packages/grid-tmux
version: ${{ needs.version.outputs.value }}

testing:
Expand All @@ -111,7 +111,7 @@ jobs:
version: ${{ needs.version.outputs.value }}

test-agent:
needs: [version, acp, core, durable-streams, runtime, terminal, testing]
needs: [version, acp, core, durable-streams, grid, runtime, testing]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/test-agent
Expand All @@ -132,7 +132,7 @@ jobs:
version: ${{ needs.version.outputs.value }}

cli:
needs: [version, acp, core, durable-streams, runtime, terminal, terminal-tmux, test-agent, testing, web, workflow]
needs: [version, acp, core, durable-streams, grid, grid-tmux, runtime, test-agent, testing, web, workflow]
uses: ./.github/workflows/publish-one.yml
with:
package: packages/cli
Expand Down
269 changes: 115 additions & 154 deletions architecture.md
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 30 additions & 26 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 11 additions & 10 deletions deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/acp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"dependencies": {
"@agentclientprotocol/sdk": "1.3.0",
"@executablemd/core": "workspace:*",
"@executablemd/grid": "workspace:*",
"@executablemd/runtime": "workspace:*",
"@executablemd/terminal": "workspace:*",
"acpx": "0.12.0",
"effection": "4.1.0"
}
Expand Down
4 changes: 2 additions & 2 deletions packages/acp/src/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ import {
cwd,
ExecutableObservationError,
} from "@executablemd/runtime";
import { nativeLaunch } from "@executablemd/terminal";
import { nativeLaunch } from "@executablemd/grid";
import type {
AgentSessionCoordinator,
AgentSessionKey,
Expand Down Expand Up @@ -2760,7 +2760,7 @@ function* useAcpxProviderState(
//
// The launch runs in a scope of its own so that this owner can bring
// it down deliberately and watch how that goes. A cancelled launch —
// the reader closing a terminal grid is one — unwinds past every
// the reader closing a grid is one — unwinds past every

@github-actions github-actions Bot Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant comment — restates what the code does.

Suggested change
// the reader closing a grid is one — unwinds past every

// statement after it, so a decision written down here would never be
// reached; written as this scope's cleanup, it is reached on every
// path there is.
Expand Down
6 changes: 3 additions & 3 deletions packages/acp/tests/native-launch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ import type {
PreparedLaunchRecord,
Session,
} from "@executablemd/core";
import { flushOutput, NativeLauncher, reserveTerminal } from "@executablemd/terminal";
import { installControlledLauncher } from "@executablemd/terminal/test";
import { flushOutput, NativeLauncher, reserveTerminal } from "@executablemd/grid";
import { installControlledLauncher } from "@executablemd/grid/test";
import type { AgentSessionCoordinator } from "@executablemd/runtime";
import type { NativeLaunchRequest } from "@executablemd/terminal";
import type { NativeLaunchRequest } from "@executablemd/grid";
import { createAcpxProvider } from "../src/provider.ts";
import type { AcpxProviderDependencies } from "../src/provider.ts";
import {
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
"@executablemd/acp": "workspace:*",
"@executablemd/core": "workspace:*",
"@executablemd/durable-streams": "workspace:*",
"@executablemd/grid": "workspace:*",
"@executablemd/grid-tmux": "workspace:*",
"@executablemd/runtime": "workspace:*",
"@executablemd/terminal": "workspace:*",
"@executablemd/terminal-tmux": "workspace:*",
"@executablemd/test-agent": "workspace:*",
"@executablemd/testing": "workspace:*",
"@executablemd/web": "workspace:*",
Expand Down
Loading
Loading