This repository was archived by the owner on Nov 12, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 12, 2019. It is now read-only.
Inspector creates a task and a group listener #353
Description
Activity
Note: this is not high priority it just creates some noise in tc-events log, and in pulseguardian logs..
But I suspect it might also put a bit of load on the browsers, so it might be worth while fixing for better end-user experience.
Is the main part of the issue live yet ?
Is the main part of the issue live yet ?
I'm not sure what you mean? Can you elaborate a bit...
Oops... :). I wanted to work on this issue, unify listener.
…On Feb 3, 2018 3:12 AM, "Jonas Finnemann Jensen" ***@***.***> wrote:
Is the main part of the issue live yet ?
I'm not sure what you mean? Can you elaborate a bit...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVLIvD_rdZdrIxk5OGQpoiYUjQpmzt0iks5tQ4FXgaJpZM4Pv6ch>
.
Awesome... I don't think anyone else have touched it, so by all means give
it a try... I'm not sure how complicated it is...
…On 2 Feb 2018 22.51, "Biboswan Roy" ***@***.***> wrote:
Oops... :). I wanted to work on this issue, unify listener.
On Feb 3, 2018 3:12 AM, "Jonas Finnemann Jensen" ***@***.***
>
wrote:
> Is the main part of the issue live yet ?
>
> I'm not sure what you mean? Can you elaborate a bit...
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/taskcluster/taskcluster-tools/
issues/353#issuecomment-362716296>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AVLIvD_
rdZdrIxk5OGQpoiYUjQpmzt0iks5tQ4FXgaJpZM4Pv6ch>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJI5OQ-CKEny0y8A6liQf19hdKvdIOGks5tRAHqgaJpZM4Pv6ch>
.
I think there is nothing like listener.unbind
True, you have to stop listening and create a new listener...
In future we might get that, that I filed an RFC for someone to rewrite
taskcluster-events and add unbind support. I think this will be a GSoC
proposal if we get a slot..
See: taskcluster/taskcluster-rfcs#104
Left working on this just thought no around is available at the moment. But looking into this issue again and not sure yet but i think including channel.unbindQueue from amqplib https://github.com/taskcluster/taskcluster-client/blob/master/src/pulselistener.js is a way to add unbind feature for the weblistener atleast.
https://github.com/taskcluster/taskcluster-tools/blob/master/src/views/UnifiedInspector/Inspector.js
We should just probably only create one listener...
Ie. listen for all events that has to do with the given taskGroupId, since we're always loading the full task group anyways right?
We don't have to listen for artifacts separately either... Just make a single pattern with the taskGroupId and bind all the exchanges.
This could reduce load on tc-events quite a bit... Right now there is a lot of reconnects all the time :)
@eliperelman,
Also is it possible that we could use something like https://developer.mozilla.org/en-US/docs/Web/API/Page_Visibility_API to detect if we should reconnect or not?
Obviously, if user hit the "notify me on changes" button to get desktop notifications when the task changes, when we have to reconnect... Is it possible that there is another API we could use to detect if the user is away from the computer?