Repository navigation
z85c30: the TCP serial console takes more than one client - #266
Merged
Merged
Conversation
A second client waited in the listen queue until the first hung up, so a script could not reach a console someone was watching. Every connected client now sees the output and may type, with telnet's own commands filtered per client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
belikh
added a commit
to irix7/iris
that referenced
this pull request
Oct 24, 2026
Upstream's README carries the whole contract: small PRs, one fix per PR, preferably one commit, bisectable. Observed practice matches it — of the last 25 merged PRs nearly all are a single commit touching one to four files, median merge latency is hours, and almost nothing is closed unmerged. Add the policy, the one-commit consequence for each unit, and the coordination notes for the contributors whose work these PRs build on (techomancer#266, techomancer#265, techomancer#279/techomancer#283, techomancer#261, techomancer#253). Credit: none of this is derived from upstream; the analysis is the fork's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z85c30: the TCP serial console takes more than one client
A second client connecting to a serial port (8880/8881) waited in the listen queue until the first one hung up, so a script could not reach a console someone was already watching (or the other way round).
The change
The TCP backend now keeps a list of connections. Every client sees all output and may type; each has its own telnet negotiation and filter, and a client that goes away is dropped without disturbing the others.
Tests
a_tcp_console_takes_more_than_one_client: two clients both get the handshake and every byte the guest sends, and what either types arrives, with telnet's own commands stripped.cargo test --lib: all pass, apart from the two tests that fail the same way onmainhere. Built in the three CI configurations.🤖 Generated with Claude Code