Repository navigation
ci: make screenshot work without a front-end renderer - #315
Merged
Merged
Conversation
A --ci instance installs no renderer, so nothing ever fills Rex3Screen::rgba and every iris-ci screenshot was black. Wait for the frame the display thread was asked to produce (bounded) and, when no renderer is present, composite the guest screen from the display caches the refresh thread just updated. A GUI renderer still supplies the readback as before.
Owner
|
i think we will have to implement something like vnc backend for gui-less stuff like ci |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
--ciinstance installs no renderer (renderer_slot()stays empty), so nothing ever fillsRex3Screen::rgbaand everyiris-ci screenshotcame out black — for example while driving a bare-metal guest whose framebuffer is visibly populated.GfxDisplay::screenshot_pending, defaultfalse; REX3 reports its existing flag).SwCompositor. A GUI renderer still supplies the readback exactly as before.Verified live against an IRIX 7 ROM:
iris-ci screenshotnow writes the guest console instead of a black frame.Tests:
cargo test --workspaceonupstream/main(1170 passed, 0 failed).