Repository navigation
net: give each bridged NFS host its own MAC - #321
Merged
Merged
Conversation
The virtual NFS host used one fixed 02:00:DE:AD:BF:53 address, so two bridged instances with different NFS subnets collided at L2 and ARP replies could reach the wrong host. Fold all four address octets into the last two, which keeps the address stable for one host and separates subnets even when only the first two octets differ. The new test fails on the fixed suffix and passes with the derivation.
16 tasks
belikh
added a commit
to irix7/iris
that referenced
this pull request
Oct 25, 2026
Cache default reverted (e7a7f62), VCE branch confirmed already converged, REX3 aux-clear test and NFS host-MAC fix opened as upstream techomancer#320/techomancer#321.
belikh
added a commit
to irix7/iris
that referenced
this pull request
Oct 25, 2026
techomancer#319, techomancer#320 and techomancer#321 are merged upstream and merged back; the send queue is renumbered around them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The virtual NFS host uses one fixed link address (
02:00:DE:AD:BF:53). Two emulators bridged onto one LAN with different NFS host addresses therefore collide at L2, and a guest's ARP entry can point at the wrong instance.Derive the last two octets by folding all four address octets, so the address is stable for one host and distinct for hosts whose addresses differ anywhere (including only in the first two octets, which a suffix-only derivation misses).
Evidence — the new test fails on upstream
mainbefore the change and passes after:It also asserts the same address always derives the same MAC, the
02:00:DE:ADprefix, and the locally-administered/unicast bits.Tests:
cargo test -p iris --lib net::nfs_pcap— 3 passed.