[shubhamrai9122-creator]

Changes

Fixes #3329

Previously, deleteCustomRuns printed a 'not found' message when customRunExists returned an error, but skipped the resource without recording the error into deleteErr. As a result, tkn customrun delete exited 0 even when specified resources were not found.

This commit records lookup errors using multierr.Append to align CustomRun delete behavior with Task and Pipeline delete:

• Missing names still print the message and are skipped.
• Existing names are still deleted and reported.
• The command returns an error if any name was not found.

Submitter Checklist

• Includes tests
• Commit messages follow commit message best practices

Release Notes

Fix tkn customrun delete to return a non-zero exit code when a specified customrun is not found.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: shubhamrai9122-creator / name: shubhamrai9122-creator (6838250)

[pratap0007]

@shubhamrai9122-creator Thank you for the contribution, could you please sign the CLA?

[Copilot]

🟢 Approval recommended

The focused fix preserves successful results, propagates failures, and includes regression coverage with no unresolved findings.

No open issues 🎉

What changed in this PR

Fixes #3329 by making tkn customrun delete return an error when a requested resource is missing, while preserving successful deletions.

Changes:

• Accumulates lookup and deletion errors.
• Strengthens error assertions and adds regression coverage for mixed successful and missing resources.

File	Description
pkg/​cmd/​customrun/​delete.go	Collects errors without stopping successful deletions.
pkg/​cmd/​customrun/​delete_test.go	Updates error expectations and tests partial success with JSON output.

_{Review effort: Balanced}

[shubhamrai9122-creator]

@pratap0007 Thanks for the review! I've signed the CLA, and the EasyCLA check is passing now. The PR is ready for another look whenever you have time.

[divyansh42]

/kind bug

[divyansh42]

Thanks for the PR @shubhamrai9122-creator 🔥
Please squash the commits into one.

[divyansh42]

/cc @pratap0007 @vdemeester

[shubhamrai9122-creator]

@divyansh42 Thanks for the review! Addressed in db8fe2c:

• Removed both inline fmt.Fprintf(s.Err, ...) prints in deleteCustomRuns. Lookup and delete failures are now reported once, through the returned error that Cobra prints. Non-NotFound lookup errors are no longer shown as "not found".
• No test depended on the removed stderr text. TestCustomRunDeleteResourceNotFound now asserts that CustomRun nonexistent not found in namespace ns-1 appears exactly once in the combined output. The delete-failure test asserts the same for failed to delete CustomRun customrun-2. Before the change those messages appeared 2 and 3 times.

go test ./pkg/cmd/customrun/... and go vet pass locally.

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyansh42, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [divyansh42,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[divyansh42]

/retest