Repository navigation
Conversation
Signed-off-by: Debashich <debashishsinha555@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hey @divyansh42 , I’ve opened a follow-up PR addressing the structured TaskRun deletion fixes as suggested. Whenever you get some time, could you please take a look? Thanks ! |
There was a problem hiding this comment.
🟡 Changes recommended
The mixed-deletion regression case uses fixtures and assertions from different test suites, leaving the central behavior change unverified.
1 open issue
What changed in this PR
This follow-up to #3086 improves structured TaskRun deletion output while preserving safeguards for TaskRuns owned by running PipelineRuns.
Changes:
- Routes warnings to stderr and skips protected TaskRuns without blocking eligible deletions.
- Emits an empty
deletedarray when nothing is deleted and adds regression tests. - Updates command help and generated documentation with JSON examples and force requirements.
| File | Description |
|---|---|
pkg/cmd/taskrun/delete.go |
Adjusts structured output, confirmation handling, and protected deletion behavior. |
pkg/cmd/taskrun/delete_test.go |
Adds structured-output and deletion regression cases. |
docs/man/man1/tkn-taskrun-delete.1 |
Updates manpage examples and safety guidance. |
docs/cmd/tkn_taskrun_delete.md |
Updates command reference examples and safety guidance. |
Review effort: Balanced
Signed-off-by: Debashich <debashishsinha555@gmail.com>
|
Hi @divyansh42, could you please rerun the failed E2E workflow when you get a chance? The failure appears unrelated to the changes in this PR. Thanks! |
|
/retest |

Changes
deletedarray when no TaskRuns are deleted in structured output.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
make checkmake generatedSee [the contribution guide](https://github.com/tektoncd/cli/blob/master/CONTRIBUTING.md) for more details.
Release Notes
Follow-up to #3086, addressing the review feedback on structured TaskRun deletion behavior.