Conversation
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit 60cd004 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tilde delimiter opens and closes strikethrough regardless of what surrounds it, so text that merely uses
~as "approximately" gets struck:main<p><s>11km / </s>750m de dénivelé</p><p>~11km / ~750m de dénivelé</p>The GFM strikethrough extension uses the same flanking rules as emphasis: an opening run may not be followed by whitespace, a closing run may not be preceded by it, and the two runs must be the same length.
league/commonmarkleaves every case in the table below alone;mainstrikes four of them.shouldParse()is unchanged.parse()now looks for a run that can actually close, and falls back to the literal text when there is none:mainleague/commonmark~struck~<s><s><del>~~struck~~<s><s><del>a~struck~b<s><s><del>~ struck ~<s>~11km / ~750m<s>11km / </s>750m~struck~~<s>~~struck~<s>Worth fixing now because #47 widened it. Those rule sets did not run
StrikethroughRulebefore, so a blockquote, a list item or a table cell could not hit this; they can now. On a personal dataset the count of wrongly struck documents roughly tripled when #47 landed, and drops to zero with this PR.A run of three or more tildes no longer delimits strikethrough either, which is what
leaguedoes and what the fenced-code rule from #42 already assumes.