Conversation
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit 9dd0642 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HtmlCommentRule::parse()ends the comment withconsumeUntil('-->'), butconsumeUntil()takes a set of characters (it isstrcspn), not a string. So the comment ends at the first-,>or<in its body, and whatever follows is parsed as Markdown:<!--start-show-more-->main<!--start-<p>show-more--></p><!--start-show-more--><!-- a - b -->breaks the same way. A comment whose body happens to contain none of those three characters —<!-- comment -->, the case the tests cover — works, which is why this went unnoticed.Parser::consumeUntilString()already exists for exactly this, and it consumes to the end of the input when the needle is absent, so an unterminated comment stays literal instead of swallowing the rest as Markdown.Tests cover a body holding
-,>and<, and an unterminated comment. Checked againstleague/commonmark, which keeps all of them intact.