Said the outcome is unknown, not that the call was aborted. - #6
Open
moedash wants to merge 1 commit into
Open
Conversation
The output synthesized for a tool call with no result read "aborted", which tells the model the command did not take effect. Nothing here knows that. The result is missing because something stopped between dispatch and the write, and after a hard kill the command may well have run, so the model should check the state before repeating it. This does not touch the interrupt path, which writes its own richer output with the wall time, so the placeholder is only reached when nothing was recorded at all.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The output synthesized for a tool call that never reported a result now says the outcome is unknown, instead of
aborted.Stacked on the panic fix, since both touch
ensure_call_outputs_present. Review that one first.Why?
abortedtells the model the command did not take effect. Nothing here knows that. The result is missing because something stopped between dispatch and the write, and after a hard kill the command may well have run, so the model should check the state before repeating it. For a coding agent the difference matters: a repeatedgit pushis not free.This does not touch the interrupt path. A real interrupt writes its own richer output with the wall time and
aborted by user, so this placeholder is only reached when nothing was recorded at all.Flagging it as the judgment call in this set: it changes model-visible text, so it is worth disagreeing with on its own rather than inside the fix it sits next to.
How did you test it?
The placeholder is shared with the tests that assert it, so the text has one home.
cargo test -p codex-core --lib context_manager::is 68/0.