Skip to content

feat: add WorkerOptions::$disablePayloadErrorLimit - #837

Merged
xepozz merged 3 commits into
masterfrom
feature/disable-payload-error-limit
Oct 21, 2026
Merged

xepozz merged 3 commits into
masterfrom
feature/disable-payload-error-limit

Conversation

@xepozz

@xepozz xepozz commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

What was changed

Added WorkerOptions::$disablePayloadErrorLimit. By default, the RoadRunner worker fails the Workflow Task with PAYLOADS_TOO_LARGE when a payload exceeds the namespace limit. The option turns this check off.

Why?

Closes #801. Merge after #836: the tests need Temporal Server 1.30+.

Checklist

  • Covered by tests

Server 1.31 (temporalio/temporal#9091) drops an empty search attribute map
from the start event, so the child workflow gets null for [].
Run the tests on CLI 1.9 (Server 1.32).
The RoadRunner worker fails the Workflow Task with PAYLOADS_TOO_LARGE
when a payload exceeds the namespace limit. The option turns this check off.
@xepozz
xepozz requested review from a team, roxblnfk and wolfy-j as code owners October 21, 2026 16:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T16:48:46.600057Z 1baafbb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@xepozz
xepozz merged commit a14de44 into master Oct 21, 2026
264 of 266 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK should fail workflow task if payloads size it known to be too large - PHP

2 participants