Skip to content

Fix data converter assignment for update headers - #839

Draft
Sushisource wants to merge 1 commit into
masterfrom
normalize-header-conversion
Draft

Sushisource wants to merge 1 commit into
masterfrom
normalize-header-conversion

Conversation

@Sushisource

Copy link
Copy Markdown
Member

What was changed

  • Assign the configured client converter as a fallback for value-backed update and update-with-start headers.
  • Preserve explicitly supplied header converters and prebuilt Payload entries without decoding/reencoding them.
  • Add one parameterized regression test covering both paths and converter choices, plus README guidance.

Breaking changes: None; explicit converters and raw payload forwarding are unchanged.
Server PR: Not required.

Why?

Part of temporalio/features#850. Unlike workflow start, these update paths omitted converter assignment, so headers created from ordinary PHP values without an explicit converter could fail serialization. PHP uses its existing converter extension point; no separate codec abstraction is introduced.

Checklist

  1. Related issue: Normalize Header Data Conversion across languages features#850 (this PR does not close the cross-SDK issue).
  2. How was this tested:
    • php -l passed for both changed implementation files and tests/Unit/Client/UpdateHeaderTestCase.php.
    • git diff --check passed; independent source review found no issues.
    • PHPUnit, coding-style checks, and Psalm could not run because Composer and vendor/ are unavailable. These checks remain unverified.
  3. Any docs updates needed? README guidance included. This repository has no changelog-fragment convention, so no new changelog infrastructure was introduced.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant