Repository navigation
Fix data converter assignment for update headers - #839
Draft
Sushisource wants to merge 1 commit into
Draft
Sushisource wants to merge 1 commit into
Sushisource wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Breaking changes: None; explicit converters and raw payload forwarding are unchanged.
Server PR: Not required.
Why?
Part of temporalio/features#850. Unlike workflow start, these update paths omitted converter assignment, so headers created from ordinary PHP values without an explicit converter could fail serialization. PHP uses its existing converter extension point; no separate codec abstraction is introduced.
Checklist
php -lpassed for both changed implementation files andtests/Unit/Client/UpdateHeaderTestCase.php.git diff --checkpassed; independent source review found no issues.vendor/are unavailable. These checks remain unverified.