Skip to content

Test custom slot supplier metadata fields - #1822

Draft
yafi-s wants to merge 1 commit into
temporalio:mainfrom
yafi-s:test/custom-slot-info-fields
Draft

Test custom slot supplier metadata fields#1822
yafi-s wants to merge 1 commit into
temporalio:mainfrom
yafi-s:test/custom-slot-info-fields

Conversation

@yafi-s

@yafi-s yafi-s commented Sep 7, 2026

Copy link
Copy Markdown

The existing custom slot supplier test checks which slot kinds are observed but does not check the metadata fields, and never executes a local activity. Extend it to validate workflow names and sticky flags, activity names, and Nexus service/operation names when slots are marked used and released.

Record the reservation kind on each permit to distinguish the structurally identical activity protocols. Check captured metadata outside the supplier callbacks, where assertion failures cannot be swallowed by the SDK's callback wrapper.

Fixes #1079.

Validation:

  • Four slot-supplier tests passed against the local dev server on Windows / Python 3.12, using the 1.32.0 wheel's native bridge with this checkout's Python source.
  • An intentionally wrong expected workflow name made the modified test fail at the expected assertion; the mutation was reverted.
  • Ruff imports/format, Pyright, basedpyright, and mypy passed for the changed file; git diff --check passed.
  • Full poe lint was attempted but stopped at type checking in the minimal environment, which lacks optional integration dependencies. Full CI remains pending.

AI-assisted contribution, opened as a draft for contributor review before requesting maintainer review.

@CLAassistant

CLAassistant commented Sep 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Ensure tests exist to confirm custom slot supplier slot info has proper fields

2 participants