Repository navigation
chore(deps): bump the production group with 21 updates #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 After merge, the Accounts demos for the t14-checkpoint devnet lose the patched ox build. viem would load stock ox 0.14.56, which lacks configurable account hash domains. The override in pnpm-workspace.yaml:35 is keyed to
'viem@ 2.57.5>ox'. Bumping viem to 2.57.7 makes it match nothing, so the lockfile now resolves viem's ox to 0.14.56. Fix: keep viem's ox on the patched build by re-keying the override to'viem@ 2.57.7>ox'(or a version-less'viem>ox') and regenerating the lockfile. Alternatively, confirm that a released ox containing wevm/ox#519 is what viem 2.57.7 resolves. [also at: package.json:67 - The account sandbox's devnet transactions may stop using the patched ox build that matches t14-checkpoint account hash domains.]Why this was flagged
pnpm-workspace.yaml:35 overrides
'viem@ 2.57.5>ox': https://pkg.pr.new/ox@ bf010ee, commented as "Configurable account hash domains matching the t14-checkpoint devnet (wevm/ox#519)". It was added in 3ae2f6b, which pointed the Accounts demos at that devnet. On base, the lockfile resolves viem@ 2.57.5 toox: https://pkg.pr.new/ox@ bf010ee(version 0.14.57-755f436.0). With viem bumped to 2.57.7 at package.json:68, the selector no longer matches. The regenerated pnpm-lock.yaml (around line 12907) resolvesviem@ 2.57.7toox: 0.14.56, which is older than the 0.14.57 preview. The lockfile's overrides header still lists the staleviem@ 2.57.5>oxentry, so the install gives no error or warning. The demos in src/components/guides/account-sandbox-devnet.ts use viem/tempo against chain 31_318. They would then compute account hashes with the default domains instead of the devnet's, so the devnet would likely reject transactions or derive the wrong addresses.Verification: pnpm-workspace.yaml still has the override
'viem@ 2.57.5>ox': https://pkg.pr.new/ox@ bf010ee. package.json changes"viem": "2.57.5"to"viem": "2.57.7", so the selector no longer matches any installed package. The regenerated snapshotviem@ 2.57.7(typescript@ 6.0.3)(zod@ 4.6.7)(pnpm-lock.yaml:12899-12907) now depends onox: 0.14.56. The base lockfile does not have this problem.