Repository navigation
fix(security): bundle PostHog extensions instead of loading them remotely - #1083
Open
0xalpharush wants to merge 3 commits into
Open
0xalpharush wants to merge 3 commits into
0xalpharush wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review found no new issues
No new issues were found in this update; 2 findings from earlier reviews are still open above.
Still open from earlier reviews (2):
- 🔴
src/components/PostHogSetup.tsx:28—If the PostHog project has web vitals or surveys turned on remotely, docs visitors will silently stop sending web-vital… - Also unresolved: 1 minor or pre-existing.
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes findings from the frontend Subresource Integrity (SRI) audit.
src/components/GoogleAnalytics.tsx: injectsgoogletagmanager.com/gtag/js?id=${VITE_GA_MEASUREMENT_ID}src/components/PostHogSetup.tsx: posthog-js (npm) lazy-loadsexception-autocapture.js(anddead-clicks-autocapture.jswhen enabled remotely) from/ingest/static(rewritten to us-assets.i.posthog.com in vercel.json) with no SRIposthog-js/dist/{dead-clicks,exception}-autocapturewith posthog-js and setsdisable_external_dependency_loading: trueNo other remote
<script>, stylesheet, modulepreload or https ESM import is in the served code (searchedsrc,public,vocs.config.tsandvite.config.ts).Checks: I didn't install dependencies or run checks locally because the shared Hand was out of memory. This is a 9-line change in one file; CI (verify.yml) covers typecheck, lint and build.