Skip to content

src: cosmetic: simplify an invalid configuration check #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyakh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

src: cosmetic: simplify an invalid configuration check #10626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f0242
src: cosmetic: simplify an invalid configuration check
lyakh Mar 16, 2026
71f7fc1
audio: src: only allocate delay lines if size changes
lyakh Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/audio/src/src_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ int src_params_general(struct processing_module *mod,
struct comp_data *cd = module_get_private_data(mod);
struct comp_dev *dev = mod->dev;
size_t delay_lines_size;
size_t old_total;
int32_t *buffer_start;
int n;
int err;
Expand Down Expand Up @@ -510,6 +511,8 @@ int src_params_general(struct processing_module *mod,
cd->source_frames = dev->frames * cd->source_rate / cd->sink_rate;
cd->sink_frames = dev->frames;

old_total = cd->param.total;

/* Allocate needed memory for delay lines */
err = src_buffer_lengths(dev, cd, cd->channels_count);
if (err < 0) {
Expand All @@ -522,21 +525,23 @@ int src_params_general(struct processing_module *mod,
* be aligned to 8 bytes as required by some Xtensa
* instructions (e.g AE_L32X2F24_XC)
*/
delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8);
if (delay_lines_size == 0) {
comp_err(dev, "delay_lines_size = 0");
if (cd->param.total == 0) {
comp_err(dev, "configuration failed: total size = 0");

return -EINVAL;
}
delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8);

Comment thread
lyakh marked this conversation as resolved.
/* free any existing delay lines. TODO reuse if same size */
mod_free(mod, cd->delay_lines);
if (!cd->delay_lines || old_total != cd->param.total) {
/* free any existing delay lines */
mod_free(mod, cd->delay_lines);

cd->delay_lines = mod_alloc(mod, delay_lines_size);
if (!cd->delay_lines) {
comp_err(dev, "failed to alloc cd->delay_lines, delay_lines_size = %zu",
delay_lines_size);
return -ENOMEM;
cd->delay_lines = mod_alloc(mod, delay_lines_size);
if (!cd->delay_lines) {
comp_err(dev, "failed to alloc cd->delay_lines, delay_lines_size = %zu",
delay_lines_size);
return -ENOMEM;
}
}

/* Clear all delay lines here */
Expand Down
Loading