tools: plugin: module: noise suppression: rework module to use sink/source - #11255
Open
softwarecki wants to merge 1 commit into
Open
softwarecki wants to merge 1 commit into
softwarecki wants to merge 1 commit into
Conversation
…ource Rework the noise suppression module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
piotrhoppeintel,
ranj063,
serhiy-katsyuba-intel,
tmleman and
wjablon1
and
a balanced review from Copilot
October 1, 2026 15:56
softwarecki
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 1, 2026 15:56
serhiy-katsyuba-intel
approved these changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Compilation errors and unsafe model-frame sizing must be corrected.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Reworks OpenVINO noise suppression for the pipeline 2.0 source/sink API.
Changes:
- Replaces legacy stream-buffer processing.
- Adds circular source/sink buffer handling.
- Updates the C/C++ processing interface.
| File | Description |
|---|---|
noise_suppression.c |
Adopts source/sink processing. |
noise_suppression_interface.h |
Updates the processing contract. |
noise_suppression_interface.cpp |
Processes circular buffers directly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+67
to
+68
| frames = source_get_data_frames_available(source); | ||
| frames = MIN(frames, sink_get_free_frames(sink)); |
| int16_t *input_data = (int16_t *)audio_stream_get_rptr(source); | ||
| int16_t *output_data = (int16_t *)audio_stream_get_wptr(sink); | ||
| uint32_t frame_count = input_buffers[0].size; | ||
| const int16_t *input_data = static_cast<const int16_t >(source->ptr); |
| inp = (char *)source->addr + | ||
| ((char *)inp - (char *)source->end_addr); | ||
| /* split each channel samples and convert to floating point */ | ||
| for (size_t i = 0, i < frame_count; i++) { |
Comment on lines
52
to
+54
| ns_process(struct processing_module *mod, | ||
| struct input_stream_buffer *input_buffers, int num_input_buffers, | ||
| struct output_stream_buffer *output_buffers, int num_output_buffers) | ||
| struct sof_source **sources, int num_of_sources, | ||
| struct sof_sink **sinks, int num_of_sinks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the noise suppression module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0.