Skip to content

ipc4: fuzz: enable BaseFW testing #11324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmleman wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −6
Open

ipc4: fuzz: enable BaseFW testing #11324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89c4c5
ipc4: helper: reject module drivers without a create op
tmleman Oct 20, 2026
ead21f7
ipc4: helper: route module_id 0 to BaseFW in fuzz builds
tmleman Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ipc/ipc4/handler-user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,7 +1582,7 @@ __cold int ipc4_user_process_module_message(struct ipc4_message_request *ipc4,
mi->primary.r.instance_id);
const struct comp_driver *drv = ipc4_get_comp_drv(IPC4_MOD_ID(comp_id));

if (!drv) {
if (!drv || !drv->ops.create) {
ret = IPC4_MOD_NOT_INITIALIZED;
break;
}
Expand Down
13 changes: 8 additions & 5 deletions src/ipc/ipc4/helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,12 @@ __cold struct comp_dev *comp_new_ipc4(const struct ipc4_module_init_instance *mo
if (!drv)
return NULL;

if (!drv->ops.create) {
tr_err(&ipc_tr, "comp 0x%x: module %u is not instantiable", comp_id,
(uint32_t)IPC4_MOD_ID(comp_id));
return NULL;
}

if (drv->type == SOF_COMP_MODULE_ADAPTER) {
const struct ipc_config_process spec = {
.data = data,
Expand Down Expand Up @@ -1361,19 +1367,16 @@ __cold static const struct comp_driver *ipc4_get_drv(const void *uuid)
* 1-based index into the runtime component driver list, counting only
* instantiable module-adapter drivers so the fuzzer's module_id space matches
* what a real signed manifest would expose.
*
* module_id 0 (BaseFW) is deliberately not mapped: BaseFW is never created as
* a pipeline component - its messages are dispatched directly by base_fw.c -
* so returning NULL for it here is correct.
*/
static const struct comp_driver *ipc4_get_fuzzer_drv(uint32_t module_id)
{
static const struct sof_uuid basefw_reg_uuid = SOF_REG_UUID(basefw);
struct comp_driver_list *dlist = comp_drivers_get();
struct list_item *iter;
uint32_t idx = 0;

if (!module_id)
return NULL;
return ipc4_search_for_drv(&basefw_reg_uuid);

list_for_item(iter, &dlist->list) {
struct comp_driver_info *inf =
Expand Down
Loading