Skip to content

Fix #149: honor THINGSDB before database discovery - #150

Open
fazmulla66-bot wants to merge 1 commit into
thingsapi:mainfrom
fazmulla66-bot:fix/thingsdb-before-discovery
Open

Fix #149: honor THINGSDB before database discovery#150
fazmulla66-bot wants to merge 1 commit into
thingsapi:mainfrom
fazmulla66-bot:fix/thingsdb-before-discovery

Conversation

@fazmulla66-bot

Copy link
Copy Markdown

Summary

  • prefer the explicit THINGSDB environment override before automatic Things App Group discovery
  • preserve existing glob-based discovery when no override is configured
  • add regression coverage for both paths

This prevents import things from stalling in filesystem discovery when callers have already supplied an exact database path.

Fixes #149

Test plan

  • pytest -q — 36 passed
  • documentation/doctest suite — 57 passed, 1 skipped
  • pycodestyle things/*.py tests/*.py
  • pydocstyle things/*.py tests/*.py
  • integration-tested through a local Things MCP against a live read-only Things database

@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

THINGSDB is ignored during import-time database discovery

1 participant