fix: address validated review findings - #4338
Open
piotr-roslaniec wants to merge 2 commits into
Open
piotr-roslaniec wants to merge 2 commits into
piotr-roslaniec wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
piotr-roslaniec
added a commit
that referenced
this pull request
Sep 23, 2026
Three follow-up fixes to the prior `fix: address validated review findings` commit, addressing findings raised by the post-PR multi-perspective review: - pkg/tbtcpg/fee.go: the bufferedFloorRate overflow guard formatted its error with `tbtc.MinWalletTxSatPerVByteFee` instead of the value that actually triggered the check (`bufferedFloorRate`). Print the correct value so operators diagnosing a huge `WalletTxFeeBufferPercent` see the buffered rate that overflowed rather than the bare floor. - pkg/bitcoin/electrum/electrum.go: drop the redundant raw `strings.Contains(rawURL, "://")` check in `validateServerURL`. The parsed `u.Scheme == ""` switch arm already rejects the same family of malformed URLs with the same error message; the raw check duplicated the work. - solidity/ecdsa/scripts/test-eslint-policy.test.mjs (new) + solidity/ecdsa/package.json: add an automated regression test for the SIGINT/SIGTERM cleanup contract in `test-eslint-policy.mjs`. The script had no test for the signal-handler path; the PR description relied on a manual smoke only. The new file uses Node's built-in test runner to spawn the script as a child process, interrupt it with SIGINT and SIGTERM mid-run, and assert no `policy-fixture-*.ts` files remain. Wired into the existing `lint:eslint-policy` script so it runs as part of `yarn lint`.
Three follow-up fixes to the prior `fix: address validated review findings` commit, addressing findings raised by the post-PR multi-perspective review: - pkg/tbtcpg/fee.go: the bufferedFloorRate overflow guard formatted its error with `tbtc.MinWalletTxSatPerVByteFee` instead of the value that actually triggered the check (`bufferedFloorRate`). Print the correct value so operators diagnosing a huge `WalletTxFeeBufferPercent` see the buffered rate that overflowed rather than the bare floor. - pkg/bitcoin/electrum/electrum.go: drop the redundant raw `strings.Contains(rawURL, "://")` check in `validateServerURL`. The parsed `u.Scheme == ""` switch arm already rejects the same family of malformed URLs with the same error message; the raw check duplicated the work. - solidity/ecdsa/scripts/test-eslint-policy.test.mjs (new) + solidity/ecdsa/package.json: add an automated regression test for the SIGINT/SIGTERM cleanup contract in `test-eslint-policy.mjs`. The script had no test for the signal-handler path; the PR description relied on a manual smoke only. The new file uses Node's built-in test runner to spawn the script as a child process, interrupt it with SIGINT and SIGTERM mid-run, and assert no `policy-fixture-*.ts` files remain. Wired into the existing `lint:eslint-policy` script so it runs as part of `yarn lint`.
piotr-roslaniec
force-pushed
the
fix/pr-4256-validated-findings
branch
from
September 23, 2026 13:17
010c27c to
41fe647
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4256 that fixes all 13 confirmed review issue groups:
Verification
go test -timeout 15m ./...go test -race -timeout 3m -count=1 ./pkg/bitcoin/electrum ./config github.com/checksum0/go-electrum/electrumgo vetstaticcheck -checks=-SA1019 ./...gofmt -l .corepack yarn lint:tsinsolidity/ecdsaactionlint -ignore 'SC2086' .github/workflows/contracts-ecdsa.yml .github/workflows/contracts-random-beacon.ymlyarn lint:eslint-policyruns