Add onError callback before error redirect in SignIn flow.

[SajidMannikeri17]

Purpose

Fire the onError callback before redirecting back to the relying party on a terminal error response. This lets consuming apps run teardown (e.g. clearing a window.onbeforeunload tab-close guard) before the browser unloads, preventing a stray "Leave site?" dialog on error redirects such as consent denial or timeout.

Approach

In SignIn's handleTerminalResponse, invoke onError?.(...) synchronously in the error branch that has a redirectUrl, immediately before setting window.location.href. Previously onError never fired on this path.

Related Issues

• 2469

Related PRs

• N/A

Checklist

• Followed the contribution guidelines.
• Manual test round performed and verified.
• Documentation provided. (Add links if there are any)
• Tests provided. (Add links if there are any)
  • Unit Tests
  • Integration Tests
• Breaking changes. (Fill if applicable)
  • Breaking changes section filled.
  • breaking change label added.

Security checks

• Followed secure coding standards.
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 2977a9d4-dcef-48e6-a512-242dc0186e16

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}