Skip to content

fix(characters): normalize spaces in spouse names - #789

Closed
tobiasehlert wants to merge 1 commit into
mainfrom
character-name-parsing
Closed

tobiasehlert wants to merge 1 commit into
mainfrom
character-name-parsing

Conversation

@tobiasehlert

Copy link
Copy Markdown
Member

Summary

  • Normalize non-breaking spaces (U+00A0) to regular spaces (U+0020) in the fansite API spouse mapping, matching existing HTML parsing.
  • Cover fansite spouse normalization and explicitly compare HTML/JSON spouse values in TestCharacterTrollefar using existing fixtures.
  • Document the married_to space behavior; leave other fields unchanged.

The observed live v4/v5 difference is documented in the issue. This change aligns both current parsing paths; the live v4 deployment discrepancy has not been independently established.

Validation

  • go test ./src -count=1
  • git diff --check

Closes #788.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@tobiasehlert tobiasehlert added bug Something isn't working go Pull requests that update Go code labels Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.87%. Comparing base (58b61d0) to head (9d17a75).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          24       24           
  Lines        3064     3064           
=======================================
  Hits         2723     2723           
  Misses        341      341           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasehlert tobiasehlert self-assigned this Oct 19, 2026
@tobiasehlert

Copy link
Copy Markdown
Member Author

Closing without merging: v5 intentionally returns plain spaces (U+0020) in character.married_to. Hosted checks for Maltusia and Trollefar confirmed consistent results from the v5 HTML and fansite parsers. The non-breaking spaces (U+00A0) in deployed v4 are an accepted version difference; v4 will receive no further updates, and v5 is the way forward. This defensive fansite normalization is therefore unnecessary.

@tobiasehlert
tobiasehlert deleted the character-name-parsing branch October 19, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

bug: inconsistent spaces in character married_to

1 participant