Repository navigation
feat(schema): caller-given metadata in V0Migrator.migrate (backfill) - #319
Merged
Merged
Conversation
ktro2828
approved these changes
Oct 22, 2026
jacoblambert
force-pushed
the
v1/cleanup
branch
from
October 22, 2026 09:58
7887797 to
f014293
Compare
…acceleration includes gravity
jacoblambert
force-pushed
the
v1/migrate-backfill
branch
from
October 22, 2026 09:59
a1096cb to
1fef36e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR lets a caller add the metadata 0.x never stored when migrating with
V0Migrator. It is what the backfill in tier4_perception_dataset (convert_t4_to_t4_v1) builds on.migrate(..., manifest_fields=...): the given manifest fields replace the defaults (provenance,project_id,generators, ...). Theirmigration_notescome after the migration's own.provenance, the note "record start / end are the first / last sample times" is not added.migrator.tables(...); the docs now say so.One spec line changes:
ego_pose.accelerationis what an IMU measures, gravity included (az ≈ +9.8 m/s² at rest). The backfill reads/sensing/imu/imu_data(base_link)./localization/accelerationis longitudinal only, and the raw Tamagawa IMU is FRD, so neither fits.Tests
test_migrate_with_backfilled_metadata: an edited vehicle and caller-given project, provenance, generators and notes end up in the written dataset, which passes sanity.Checked on three real db_j6gen2_v12 scenes (1d095bce, 610e6b9f, 3a0c82f1):
t4sanity --checksum101 passed, 0 failed. Vehicle, map ids, provenance, Autoware version, ego twist / acceleration / GNSS and vehicle state are filled;REC025(placeholders) no longer warns.Related PRs/branches: