Skip to content

Fix public ExecutionContext attribute types - #57

Merged
lukasbindreiter merged 3 commits into
mainfrom
fix/execution-context-attribute-types
Sep 14, 2026
Merged

lukasbindreiter merged 3 commits into
mainfrom
fix/execution-context-attribute-types

Conversation

@snamber

@snamber snamber commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Declare current_task and job_cache on the public ExecutionContext, so task execute methods can use them without casts or type-checker suppressions.
  • Add a regression test for display updates and cache writes, and remove obsolete suppressions.
  • Install Git LFS when missing and fetch test fixtures during orb setup.

Runtime behavior and lightweight task-authoring imports are unchanged. The demo notebook is outside the repository and is not included.

Verification

  • uv run --frozen ty check passed.
  • Ruff lint and format checks passed for changed Python files.
  • Workflows tests: 226 passed, 1 skipped.
  • Setup syntax check and two consecutive setup runs passed; all 15 LFS files were materialized.
  • Oracle reviewed the complete diff and found no actionable issues.

The setup runs used an already-installed Git LFS; the conditional installation branch was not exercised within the script.

snamber and others added 3 commits September 14, 2026 15:08
Declare current_task and job_cache on the public ExecutionContext so task implementations can access them without type-checker suppressions.

Cover display updates and cache writes through the public context annotation, and remove obsolete cache attribute suppressions.

Amp-Thread-ID: https://ampcode.com/threads/T-01a08fdb-a191-76de-acc8-b67cb695cbdc
Co-authored-by: Amp <amp@ampcode.com>
@lukasbindreiter
lukasbindreiter force-pushed the fix/execution-context-attribute-types branch from b9ec10a to 2c644b0 Compare September 14, 2026 13:11
@lukasbindreiter
lukasbindreiter merged commit d984d7f into main Sep 14, 2026
8 checks passed
@lukasbindreiter
lukasbindreiter deleted the fix/execution-context-attribute-types branch September 14, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants