Conversation
`define_gcs_connection` now accepts `hmac_access_id`/`hmac_secret` as a mutually-exclusive alternative to `service_account_credentials_json`, mirroring the Forward CLI's gcloud_storage_hmac/gcloud_storage_sa split and the existing arn-vs-access_key/secret pattern already used for S3. Threaded through the schema layer (define_gcs_connection validation), the forward generator (GCS_HMAC_ACCESS_ID/GCS_HMAC_SECRET datafile directives), and the reverse migrate parser/TS emitter for full round-trip support. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcloud_storage/gcloud_storage_hmac/gcloud_storage_saconnector types;define_gcs_connectionpreviously only supported the service-account JSON case.hmac_access_id/hmac_secret) as a mutually-exclusive alternative toservice_account_credentials_json, mirroring the existingarnvs.access_key/secretpattern already used for S3 connections in this SDK (oneconnectionabstraction, pluggable auth, singleTYPE gcsdatafile — consistent with how S3's two auth variants both stay underTYPE s3).define_gcs_connectionvalidation), forward generator (GCS_HMAC_ACCESS_ID/GCS_HMAC_SECRETdatafile directives), and the reverse migrate parser + TypeScript emitter, for full round-trip support.Closes PROTM-2261: https://linear.app/tinybird/issue/PROTM-2261/python-sdk-add-gcs-hmacservice-account-connector-distinction
Checklist
lint,typecheck,test)pre-commit run --all-filespasses locally (gitleaks step fails in this sandbox on an unrelated SSL/network error fetching its pre-commit env; not a code issue)README.md) with an HMAC connection exampleCHANGELOG.mdwas updated when user-facing behavior changed