Repository navigation
build: require Python 3.10 and pin the turnkey-sdk-types floor - #39
Merged
Merged
Conversation
The generated client uses a PEP 604 union that Python 3.9 evaluates at import time, so import turnkey_http raised TypeError there while the metadata claimed 3.8 support. The three packages now require 3.10. turnkey-http now requires turnkey-sdk-types>=0.2.0, so a resolver cannot pair it with the 0.1.0 types that lack the activity error classes. The stamper floor is >=0.1.0: 0.1.1 only raises the Python floor, and CI installs the local stamper before the release bumps it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
figitaki
marked this pull request as ready for review
October 21, 2026 01:23
moeodeh3
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fixes from the closed release PR #31 did not reach PyPI. The v2026.10.1 and v2026.10.2 releases were cut from main, and this commit was only on the #31 branch. This PR brings it to main.
Problems on PyPI now
turnkey-http0.2.1 depends onturnkey-sdk-typeswith no version floor. If 0.1.0 types are already installed, pip keeps them, andimport turnkey_httpfails withNameError: name 'GetActivePoliciesBody' is not defined. I reproduced this from PyPI.requires-python >=3.8. The generated client uses atype[T] | Noneannotation, soimport turnkey_httpraisesTypeErroron Python 3.9. This is the floor part of Raise the Python floor to 3.10 and modernize packaging #29.Changes
turnkey-httpnow requiresturnkey-sdk-types>=0.2.0andturnkey-api-key-stamper>=0.1.0.httpandsdk-types, one forapi-key-stamper.The stamper floor is
>=0.1.0, not>=0.1.1as in #31. Stamper 0.1.1 only raises the Python floor, soturnkey-httpneeds nothing from it. A>=0.1.1floor also breaks CI, because CI installs the local 0.1.0 stamper in editable mode before the release bumps it.#35 raises the floor to 3.11. This PR uses 3.10 because CI builds on 3.10 to 3.12. #35 can raise it later.
Tests
make format-checkandmake typecheckpass.http[dev]) resolves and imports.The release is in the stacked PR.
🤖 Generated with Claude Code