Repository navigation
Conversation
Set Pydantic's defer_build on TurnkeyBaseModel so each generated model builds its validator and serializer on first use instead of at import. Only enabled on Pydantic 2.5+; older versions keep the current behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
turnkey_sdk_typesbuilds all ~1,300 Pydantic models up front, which takes seconds and hundreds of MB. This setsdefer_buildonTurnkeyBaseModelso each model builds on first use.Enabled on Pydantic 2.5+ only. In testing, deferred building crashes when a model is serialized before it's validated in 2.1–2.2, and fails intermittently under concurrent first use in 2.3–2.4, so those versions keep the current behavior.
defer_builddoesn't exist in 2.0. Thepydantic>=2.0.0requirement is unchanged.Impact (Python 3.12, Pydantic 2.14,
import turnkey_http): 1.38s → 0.16s, 283MB → 59MB.Testing: with vs. without the change on Python 3.10–3.14 × Pydantic 2.0–2.14. On 2.5+, schemas, dumps, validation errors and first-use behavior were identical across all models, with no new failures under concurrent use. The existing tests and live API calls also gave identical results.
🤖 Generated with Claude Code