Repository navigation
fix(release): pin GoReleaser to the pushed tag - an rc on the same commit won - #54
Merged
Merged
Conversation
…mmit won Why: The v0.6.0 run 42421835716 (attempt 1) released as v0.6.0-rc.2. Both tags were on 888e090, and GoReleaser's default `git tag --points-at HEAD --sort=-version:refname` ranks the rc first. ghcr v0.6.0 and latest got a binary that reports 0.6.0-rc.2. Approach: Set GORELEASER_CURRENT_TAG to github.ref_name on tag runs. GoReleaser ignores an empty value, so dispatch snapshots do not change. The binary smoke step now stops the run before the image push if `version` does not match the tag. Learned: The snapshot cannot find this, because it never resolves a tag. A check after GoReleaser is too late for the GitHub release, but not for the image. Next: The next tag validates it. kaibo's release.yml probably needs the same fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 9, 2026
tobert
added a commit
that referenced
this pull request
Nov 9, 2026
Why: Amy: "we'll get a 0.6.2 rolling to do an e2e". We agreed on 0.6.1, because 0.6.0 is the last release. Approach: Two terse bullets. The actions bumps (#55) and the docs (#56) do not change what users get. Next: Tag v0.6.1-rc.1, then v0.6.1 on the same commit to test #54. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
GORELEASER_CURRENT_TAGto the pushed tag on tag runs. The binary smoke step now fails the run before the image push whenotel-cli versiondoes not match the tag.The v0.6.0 run 42421835716 (attempt 1) released as
v0.6.0-rc.2, because both tags pointed to 888e090. GoReleaser's defaultgit tag --points-at HEAD --sort=-version:refnameranksv0.6.0-rc.2abovev0.6.0. ghcrv0.6.0andlatestgot a binary that reports0.6.0-rc.2. We deleted the rc.2 tag and re-ran the job to recover.GoReleaser ignores an empty
GORELEASER_CURRENT_TAG(getFromEnvcheckstag != ""ininternal/pipe/git/git.go). Dispatch snapshots therefore do not change. The snapshot cannot find this problem, because it never resolves a tag. The next tag push is the real test.Verification
actionlint did not run locally. CI's goreleaser snapshot job runs this workflow's config.
🤖 Generated with Claude Code