Skip to content

[TCL-7759] fix: restrict Slurm health checks to idle nodes - #40

Merged
jhu-svg merged 5 commits into
slurm-1.0-together-changesfrom
TCL-7759/align-health-check-default
Aug 30, 2026
Merged

jhu-svg merged 5 commits into
slurm-1.0-together-changesfrom
TCL-7759/align-health-check-default

Conversation

@jhu-svg

@jhu-svg jhu-svg commented Aug 28, 2026 •

Copy link
Copy Markdown

Summary

  • make the Slinky system default HealthCheckNodeState=IDLE, matching TCCO's current effective policy
  • add regression coverage that rejects the unsafe ANY default
  • make full-repository lint non-mutating and enforce it in pull-request CI
  • publish the change under the unused immutable operator tag 1.0.15

This is stage 1 of TCL-7759. Keep the ticket open and do not remove TCCO's duplicate health-check directives until 1.0.15 is released and adopted by every cleanup target.

Follow-up stack

Linear

https://linear.app/together-ai/issue/TCL-7759/fix-duplicate-slurm-config-entries

Test plan

  • GOTOOLCHAIN=go1.25.3 make helm-validate test golangci-lint
  • git diff origin/slurm-1.0-together-changes...HEAD | gitleaks stdin --redact --no-banner
  • Codex review: no actionable findings

@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

✅ Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.3-Flash) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@jhu-svg
jhu-svg marked this pull request as ready for review August 30, 2026 23:52
@jhu-svg
jhu-svg merged commit 1668b05 into slurm-1.0-together-changes Aug 30, 2026
3 checks passed
@jhu-svg
jhu-svg deleted the TCL-7759/align-health-check-default branch August 30, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants