fix: avoid recreating log FIFO after EOF [tcl-9220] - #41
Merged
sagrawal-byte merged 1 commit intoAug 28, 2026
Merged
Conversation
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
sagrawal-byte
force-pushed
the
sagrawal/fix-logfile-fifo
branch
from
August 28, 2026 21:46
362e240 to
d083a3c
Compare
sagrawal-byte
changed the base branch from
release-1.0
to
slurm-1.0-together-changes
August 28, 2026 21:48
Never rm/recreate an existing FIFO, and reopen after writer EOF; the old exit-and-recreate cycle raced a respawning slurmctld into a permanently blocked fifo_open on an unlinked inode. Signed-off-by: Austin Fuller <afuller@crusoe.ai> Changelog: Fixed - Fixed cases where slurmctld would get blocked by fifo_open on an unlinked inode from logfile sidecar.
sagrawal-byte
force-pushed
the
sagrawal/fix-logfile-fifo
branch
from
August 28, 2026 21:54
d083a3c to
37a0a0a
Compare
eb3095
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
sh -n internal/builder/scripts/logfile.shmake test— existing module-path mismatch onmain:cmd/managerandcmd/webhookimportgithub.com/SlinkyProject/slurm-operator/...whilego.moddeclaresgithub.com/togethercomputer/slurm-operator; remaining packages passMade with Cursor