Skip to content

fix: avoid recreating log FIFO after EOF [tcl-9220] - #41

Merged
sagrawal-byte merged 1 commit into
slurm-1.0-together-changesfrom
sagrawal/fix-logfile-fifo
Aug 28, 2026
Merged

sagrawal-byte merged 1 commit into
slurm-1.0-together-changesfrom
sagrawal/fix-logfile-fifo

Conversation

@sagrawal-byte

Copy link
Copy Markdown

Summary

  • cherry-pick SlinkyProject/slurm-operator@4abbf53
  • preserve an existing log FIFO and reopen it after writer EOF, preventing Slurm daemons from blocking on an unlinked FIFO inode during reconfigure

Test plan

  • sh -n internal/builder/scripts/logfile.sh
  • make test — existing module-path mismatch on main: cmd/manager and cmd/webhook import github.com/SlinkyProject/slurm-operator/... while go.mod declares github.com/togethercomputer/slurm-operator; remaining packages pass

Made with Cursor

@broly-code-security-scanner

broly-code-security-scanner Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Broly Security Scan

Note

✅ Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.3-Flash) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@sagrawal-byte sagrawal-byte changed the title fix: avoid recreating log FIFO after EOF fix: avoid recreating log FIFO after EOF [tcl-9220] Aug 28, 2026
@sagrawal-byte
sagrawal-byte changed the base branch from main to release-1.0 August 28, 2026 21:46
@sagrawal-byte
sagrawal-byte force-pushed the sagrawal/fix-logfile-fifo branch from 362e240 to d083a3c Compare August 28, 2026 21:46
@sagrawal-byte
sagrawal-byte changed the base branch from release-1.0 to slurm-1.0-together-changes August 28, 2026 21:48
Never rm/recreate an existing FIFO, and reopen after writer EOF; the old
exit-and-recreate cycle raced a respawning slurmctld into a permanently
blocked fifo_open on an unlinked inode.

Signed-off-by: Austin Fuller <afuller@crusoe.ai>
Changelog: Fixed - Fixed cases where slurmctld would get blocked by
 fifo_open on an unlinked inode from logfile sidecar.
@sagrawal-byte
sagrawal-byte force-pushed the sagrawal/fix-logfile-fifo branch from d083a3c to 37a0a0a Compare August 28, 2026 21:54
@sagrawal-byte
sagrawal-byte merged commit 8575c47 into slurm-1.0-together-changes Aug 28, 2026
3 checks passed
@sagrawal-byte
sagrawal-byte deleted the sagrawal/fix-logfile-fifo branch August 28, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants