Skip to content

[TCL-9479] feat(nodeset): reconcile compute class features - #43

Merged
sagrawal-byte merged 4 commits into
slurm-1.0-together-changesfrom
sagrawal/reconcile-compute-class-features
Sep 14, 2026
Merged

sagrawal-byte merged 4 commits into
slurm-1.0-together-changesfrom
sagrawal/reconcile-compute-class-features

Conversation

@sagrawal-byte

Copy link
Copy Markdown

Summary

  • read together.ai/compute-class from each worker pod’s Kubernetes node
  • reconcile preemptible and non-preemptible into Slurm Features and FeaturesAct
  • enqueue NodeSets when nodes are created or their compute class changes
  • compare feature collections without depending on Slurm’s ordering

Depends on https://github.com/togethercomputer/together-cloud-cluster-operator/pull/908.

Verification

  • go test ./internal/controller/nodeset/slurmcontrol
  • golangci-lint run

The fork currently declares the togethercomputer module path while its internal imports use SlinkyProject; verification temporarily aligned the module declaration and did not include a go.mod change.

@broly-code-security-scanner

broly-code-security-scanner Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Broly Security Scan

Note

✅ Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.3) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@sagrawal-byte
sagrawal-byte changed the base branch from main to slurm-1.0-together-changes September 8, 2026 22:52
Co-authored-by: Cursor <cursoragent@cursor.com>
@sagrawal-byte
sagrawal-byte force-pushed the sagrawal/reconcile-compute-class-features branch from 3771de3 to 66caa2e Compare September 8, 2026 22:53
@sagrawal-byte sagrawal-byte changed the title feat(nodeset): reconcile compute class features feat(nodeset): reconcile compute class features Sep 10, 2026
@sagrawal-byte sagrawal-byte changed the title feat(nodeset): reconcile compute class features [TCL-9479] feat(nodeset): reconcile compute class features Sep 11, 2026
sagrawal-byte and others added 3 commits September 11, 2026 09:52
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sagrawal-byte
sagrawal-byte merged commit 581c99f into slurm-1.0-together-changes Sep 14, 2026
3 checks passed
@sagrawal-byte
sagrawal-byte deleted the sagrawal/reconcile-compute-class-features branch September 14, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants