Repository navigation
[TCL-9922] slurm: add liveness probe support to login deployment - #47
Merged
sagrawal-byte merged 1 commit intoSep 29, 2026
Merged
Conversation
The login deployment template now renders .Values.login.livenessProbe, matching the existing readinessProbe support added in #46. This lets TCCO wire a liveness probe so Kubernetes restarts the login pod when sackd or TorchPass login services die, instead of leaving the pod in a degraded state indefinitely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
neerajshah-ux
approved these changes
Sep 29, 2026
Part-TimeWizard
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
livenessProberendering to the login Deployment template, matching the existingreadinessProbesupport from fix(slurm): [TCL-7552] render TorchPass readiness probes #46.login.livenessProbetovalues.yaml(default{}).This lets TCCO wire a liveness probe so Kubernetes restarts the login pod when sackd or TorchPass login services die, instead of leaving the pod degraded with only readiness failing.
Test plan
helm templaterenders livenessProbe whenlogin.livenessProbeis sethelm templateomits livenessProbe when value is{}🤖 Generated with Claude Code