Skip to content

[TCL-9922] slurm: add liveness probe support to login deployment - #47

Merged
sagrawal-byte merged 1 commit into
slurm-1.0-together-changesfrom
sagrawal/login-liveness-probe
Sep 29, 2026
Merged

sagrawal-byte merged 1 commit into
slurm-1.0-together-changesfrom
sagrawal/login-liveness-probe

Conversation

@sagrawal-byte

Copy link
Copy Markdown

Summary

This lets TCCO wire a liveness probe so Kubernetes restarts the login pod when sackd or TorchPass login services die, instead of leaving the pod degraded with only readiness failing.

Test plan

  • helm template renders livenessProbe when login.livenessProbe is set
  • helm template omits livenessProbe when value is {}
  • Deploy with TCCO setting the probe and verify pod restarts on sackd failure

🤖 Generated with Claude Code

The login deployment template now renders .Values.login.livenessProbe,
matching the existing readinessProbe support added in #46. This lets
TCCO wire a liveness probe so Kubernetes restarts the login pod when
sackd or TorchPass login services die, instead of leaving the pod in a
degraded state indefinitely.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

✅ Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (GLM-5.3-Flash) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Attack Hypotheses · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@sagrawal-byte sagrawal-byte changed the title feat(slurm): add liveness probe support to login deployment [TCL-9922] slurm: add liveness probe support to login deployment Sep 29, 2026
@sagrawal-byte
sagrawal-byte merged commit 95b9b67 into slurm-1.0-together-changes Sep 29, 2026
3 checks passed
@sagrawal-byte
sagrawal-byte deleted the sagrawal/login-liveness-probe branch September 29, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants