Repository navigation
fix(desktop): approval timeout/stale-click close events (#4250) - #4264
Merged
Merged
Conversation
…UI ends (#4250) Co-Authored-By: ggcode <noreply@ggcode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
根因
审批 15 分钟超时只在 agent 侧收场(Deny+continue):broker 无 onCancel 钩子、finishRun 只推全局 StatusIdle——桌面模态框(全屏遮罩)与移动审批卡(键控同 ID result)永久悬挂;迟到点击 ResolveApproval ok=false 早退,决策静默丢弃且移动端连 PushTunnelApprovalResult 都不执行。
修(issue 方向三落点)
前端消费面零改动(Layout.tsx 既有 approval:cancel 监听;移动端同 ID result 即清卡)。ask_user 同形面 issue 未报,PR 注明留谱系。
验证
伴测(stale 双端通知直证)+wailskit 全包 11.6s ok+build 绿。
Closes #4250