Repository navigation
Conversation
What was broken Marathon Match All Submissions omitted the provisional and final rank columns available on the old platform. Root cause The Opportunities table displayed scores but did not calculate or render ranks. Date sorting loaded individual pages, which cannot provide challenge-wide rankings. What was changed Add sortable Final Rank and Provisional Rank columns exclusively to Marathon Match All Submissions, with mobile labels and sort options. Rank the complete latest-submission collection before pagination using the existing score resolver and final-score release gate. Preserve the legacy provisional timestamp tie-break and shared final competition ranks. Update the table widths and documentation. Any added/updated tests Add 10 regression cases covering ties, missing and pending scores, resolved summations, both rank sort directions, global pagination, mobile sorting, release timing, and non-MM exclusions. Extend My Submissions coverage to verify its columns remain unchanged. All 713 Opportunities tests pass. The full suite's 22 failing suites and 19 failed tests also reproduce on untouched origin/dev.
Preserve global Marathon Match ranks alongside the 200-row default from dev. Update pagination coverage and API expectations for full-collection ranking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Marathon Match All Submissions was missing the Final Rank and Provisional Rank columns shown on the old platform.
Root cause
The Opportunities table rendered scores without calculating ranks. Its default date ordering fetched individual pages, which cannot produce challenge-wide rankings.
What was changed
Files changed:
ChallengeDetailsPage.tsx,ChallengeDetailsPage.module.scss,ChallengeDetailsPage.flows.spec.tsx,marathon-match.utils.ts,marathon-match.utils.spec.ts, andsrc/apps/opportunities/README.md.Any added/updated tests
nvm usebefore all Node/Yarn commands.yarn lint: passed.NODE_OPTIONS=--max-old-space-size=12288 yarn run build: passed with existing repository warnings. The initial default-heap build exhausted Node's heap.yarn test:no-watch --runInBand src/apps/opportunities: all 713 tests in 61 suites passed.yarn test:no-watch --runInBand: 387 suites and 2,736 tests passed; 22 suites failed, including 19 failed tests. The identical failing suites and test cases reproduce on untouchedorigin/dev(2,726 passing tests). These existing failures include module-resolution, mocks, and unrelated expectation failures and require separate fixes.