Repository navigation
fix: leave library sourcemaps off unless the caller asks - #131
Merged
Merged
Conversation
Pin Vite+ 1.5.0 and map the vite package to @voidzero-dev/vite-plus-core so the workspace resolves one toolchain.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
arch1995
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
libraryPresetemitted sourcemaps when the caller omittedsourcemap. This change turns that default off. The workspace also pins Vite+ 1.5.0 and maps thevitepackage to@voidzero-dev/vite-plus-core@1.5.0, so install resolves one toolchain.Jira Link
N/A
Description
libraryPresetusessourcemap: falseunless the caller setssourcemap: true.vite-plus@1.5.0.vitetonpm:@voidzero-dev/vite-plus-core@1.5.0..gitignoreignores.vitest/.Callers who need maps set
sourcemap: true.How has this been tested?
npm test— 9 files, 120 tests passedScreenshots (if appropriate)
N/A
Types of changes
The preset option is unchanged. Callers who omit
sourcemapno longer get map files. Setsourcemap: trueto keep them.Checklist
Summary
viteto Vite+ core.Test plan
npm test(120 passed)changeset statusaccepts.changeset/library-sourcemap-default.mdsourcemap: trueNote
Medium Risk
Default build output changes for every consumer using
libraryPresetwithout an explicitsourcemapflag, plus a pinned Vite+ toolchain bump across the monorepo.Overview
libraryPresetnow defaultssourcemaptofalsewhen callers omit it (wastrue). Opt in withsourcemap: true. Contract tests,torus-scriptsown pack config, and the migration skill example match the new default. A patch changeset records@toruslabs/torus-scripts.The workspace pins
vite-plus@1.5.0(exact) and adds an npmoverridesentry soviteresolves to@voidzero-dev/vite-plus-core@1.5.0, with lockfile and README updates..gitignorenow ignores.vitest/.Reviewed by Cursor Bugbot for commit 7291658. Bugbot is set up for automated code reviews on this repo. Configure here.