Skip to content

fix: leave library sourcemaps off unless the caller asks - #131

Merged
chaitanyapotti merged 1 commit into
mainfrom
chore/vite-plus-1.5
Nov 12, 2026
Merged

chaitanyapotti merged 1 commit into
mainfrom
chore/vite-plus-1.5

Conversation

@chaitanyapotti

@chaitanyapotti chaitanyapotti commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Motivation and Context

libraryPreset emitted sourcemaps when the caller omitted sourcemap. This change turns that default off. The workspace also pins Vite+ 1.5.0 and maps the vite package to @voidzero-dev/vite-plus-core@1.5.0, so install resolves one toolchain.

Jira Link

N/A

Description

  • libraryPreset uses sourcemap: false unless the caller sets sourcemap: true.
  • The package pack config and the migration example use the same setting.
  • The root devDependency is exact vite-plus@1.5.0.
  • A root override maps vite to npm:@voidzero-dev/vite-plus-core@1.5.0.
  • .gitignore ignores .vitest/.
  • The root README now names Vite+ 1.5.0.
  • A patch changeset records the preset default.

Callers who need maps set sourcemap: true.

How has this been tested?

  • npm test — 9 files, 120 tests passed
  • CI validate workflow on this pull request

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

The preset option is unchanged. Callers who omit sourcemap no longer get map files. Set sourcemap: true to keep them.

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Summary

  • Library builds leave sourcemaps off unless the caller asks for them.
  • The workspace pins Vite+ 1.5.0 and aliases vite to Vite+ core.

Test plan

  • npm test (120 passed)
  • Confirm CI changeset status accepts .changeset/library-sourcemap-default.md
  • Confirm a consumer that needs maps sets sourcemap: true

Note

Medium Risk
Default build output changes for every consumer using libraryPreset without an explicit sourcemap flag, plus a pinned Vite+ toolchain bump across the monorepo.

Overview
libraryPreset now defaults sourcemap to false when callers omit it (was true). Opt in with sourcemap: true. Contract tests, torus-scripts own pack config, and the migration skill example match the new default. A patch changeset records @toruslabs/torus-scripts.

The workspace pins vite-plus@1.5.0 (exact) and adds an npm overrides entry so vite resolves to @voidzero-dev/vite-plus-core@1.5.0, with lockfile and README updates. .gitignore now ignores .vitest/.

Reviewed by Cursor Bugbot for commit 7291658. Bugbot is set up for automated code reviews on this repo. Configure here.

Pin Vite+ 1.5.0 and map the vite package to @voidzero-dev/vite-plus-core so the workspace resolves one toolchain.
@chaitanyapotti
chaitanyapotti requested review from a team as code owners November 12, 2026 07:09
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvite-plus@​1.4.0 ⏵ 1.5.098 +110010099 -1100

View full report

@chaitanyapotti
chaitanyapotti merged commit 5a4e8bd into main Nov 12, 2026
14 checks passed
@chaitanyapotti
chaitanyapotti deleted the chore/vite-plus-1.5 branch November 12, 2026 07:15
@tuna1207 tuna1207 mentioned this pull request Nov 12, 2026
5 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants