Repository navigation
Update SignSubtree to match updated specs - #287
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 82.57% 88.53% +5.96%
==========================================
Files 5 10 +5
Lines 241 1012 +771
==========================================
+ Hits 199 896 +697
- Misses 30 116 +86
+ Partials 12 0 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roger2hk
approved these changes
Oct 12, 2026
| return false | ||
| } | ||
| return v.verifySubtree(logOrigin, start, end, hash, sigRaw) | ||
| return v.verifySubtree(logOrigin, start, end, hash, sig) |
Contributor
There was a problem hiding this comment.
Do you want to rename hash to root like what you did in SubtreeVerifier interface?
AlCutter
force-pushed
the
raw_subtree_cosigs
branch
from
October 13, 2026 12:58
316df85 to
9bd54a2
Compare
roger2hk
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: