Skip to content

Update SignSubtree to match updated specs - #287

Merged
AlCutter merged 4 commits into
transparency-dev:mainfrom
AlCutter:raw_subtree_cosigs
Oct 13, 2026
Merged

AlCutter merged 4 commits into
transparency-dev:mainfrom
AlCutter:raw_subtree_cosigs

Conversation

@AlCutter

Copy link
Copy Markdown
Collaborator

This PR:

  • Updates the MLDSA SignSubtree implementation to match the updated tlog-cosignature and MTC specs, returning raw MLDSA cosignatures rather than note-style signatures.
  • Expands the test coverage to include those checks listed in the PLANTS RFC, and adds an interop test for MLDSA note cosigs with Torchwood.
  • Introduces a few small tidy-ups.

@AlCutter
AlCutter requested a review from roger2hk October 12, 2026 13:54
@AlCutter
AlCutter requested a review from a team as a code owner October 12, 2026 13:54
@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (fa00c16) to head (9bd54a2).
⚠️ Report is 197 commits behind head on main.

Files with missing lines Patch % Lines
note/note_cosigv1.go 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   82.57%   88.53%   +5.96%     
==========================================
  Files           5       10       +5     
  Lines         241     1012     +771     
==========================================
+ Hits          199      896     +697     
- Misses         30      116      +86     
+ Partials       12        0      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread note/note_cosigv1.go Outdated
return false
}
return v.verifySubtree(logOrigin, start, end, hash, sigRaw)
return v.verifySubtree(logOrigin, start, end, hash, sig)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to rename hash to root like what you did in SubtreeVerifier interface?

@AlCutter
AlCutter merged commit 340a9e5 into transparency-dev:main Oct 13, 2026
14 checks passed
@AlCutter
AlCutter deleted the raw_subtree_cosigs branch October 13, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants