Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds the shared API. Nothing calls it yet:
PartialResourceIO: the tile and entry bundle I/O, provided by each storage implementation.EnsureGeometry: ported fromstorage/posix(ensureGeometry,ensurePartialBundle,ensurePartialTile,maxLevel).MarshalTlogEntryBundle: ported fromstorage/posix(marshalTlogEntryBundle).Differences from the existing POSIX implementation:
PartialResourceIO.stat. These reads must not fall back to the full resource, asLogReader.ReadTile/ReadEntryBundledo. Otherwise, whenever the tree's tile is already full, a missing partial is never created.%w.The next few PRs will wire POSIX and GCP to this new API.