Repository navigation
Deployment/gcp: use hyperdisk-balanced boot disk for C4 and N4 VMs - #968
Merged
Merged
Conversation
AlCutter
reviewed
Oct 20, 2026
| auto_delete = true | ||
| boot = true | ||
| // C4 and N4 machine series require Hyperdisk for boot disks and do not support pd-standard. | ||
| disk_type = startswith(var.machine_type, "c4-") || startswith(var.machine_type, "n4-") ? "hyperdisk-balanced" : "pd-standard" |
Collaborator
There was a problem hiding this comment.
I think you could do a regex of ^.4.* to be more general - Gemini sez all {C,N}4{A,D,X} machines require hyperdisk boot disks.
Alternatively, flip it and look for {N,E}1.* for PD and default to hyperdisk?
AlCutter
reviewed
Oct 20, 2026
| boot = true | ||
| // Gen 4+ machine series require hyperdisk-balanced; Gen 3 (plus t2a/g2) require pd-balanced; | ||
| // Gen 1/2 default to pd-standard. | ||
| disk_type = can(regex("^[a-z]+[4-9][a-z]*-", var.machine_type)) ? "hyperdisk-balanced" : ( |
Collaborator
There was a problem hiding this comment.
Probably want the i modifier to make these case-insensitive
AlCutter
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.