Skip to content

fix(swift): drop WasmKit from TraverseEmbedder for Nightly macOS - #310

Merged
enricopiovesan merged 1 commit into
mainfrom
cursor/ticket-fix-nightly-macos-wasmkit-dep-drop-wasmkit
Sep 17, 2026
Merged

enricopiovesan merged 1 commit into
mainfrom
cursor/ticket-fix-nightly-macos-wasmkit-dep-drop-wasmkit

Conversation

@enricopiovesan

Copy link
Copy Markdown
Contributor

Summary

  • Remove deprecated WasmKit (+ swift-system) from vendor/traverse-embedder-swift; production path is already WasmiHostBridgeClient / TraverseSwiftHost.
  • Extract TraverseBridgeError + TraverseBridgeClient into BridgeClient.swift so they are no longer nested under the WasmKit client file.
  • Restores Nightly native-macos by eliminating WasmKit SystemExtras Stat vs stat compile failures.

Governing Spec

  • docs/quality-standards.md (Nightly Apple required)
  • Spec 068 embedder-api (Wasmi host path)

Project Item

  • Ticket ID: fix-nightly-macos-wasmkit-dep
  • Project 2 item: PVTI_lADOEbiBt84BbzAzzg7c-gs

Definition of Done

  • Package.swift has no WasmKit / swift-system dependencies
  • Deprecated WasmKit sources removed; bridge protocol/error retained
  • Package.resolved removed (no remote source packages)
  • Vendor README documents Wasmi-only path
  • Local xcodebuild build+test green for TraverseStarterMac and MeetingNotesMac

Validation

  • bash scripts/ci/repository_checks.sh
  • xcodebuild -scheme TraverseStarterMac -destination 'platform=macOS' build test CODE_SIGNING_ALLOWED=NO
  • xcodebuild -scheme MeetingNotesMac -destination 'platform=macOS' build test CODE_SIGNING_ALLOWED=NO
  • After merge: Nightly native-macos (or workflow_dispatch)

Made with Cursor

WasmiHostBridgeClient is the production path; removing WasmKit stops Xcode from compiling SystemExtras against a mismatched swift-system (Stat vs stat).

Co-authored-by: Cursor <cursoragent@cursor.com>
@enricopiovesan
enricopiovesan enabled auto-merge (squash) September 17, 2026 15:58
@enricopiovesan
enricopiovesan merged commit de8e686 into main Sep 17, 2026
8 checks passed
@enricopiovesan
enricopiovesan deleted the cursor/ticket-fix-nightly-macos-wasmkit-dep-drop-wasmkit branch September 17, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant