Repository navigation
Delegate default CA selection to HTTPClient - #165
Merged
Merged
Conversation
yyuu
marked this pull request as ready for review
October 23, 2026 10:24
|
Coverage is 79.883% — remove-td-client-ca-bundle into master. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:verifyandAPI#ssl_ca_file=settings to both regular API and bulk load requests. Recreate the bulk load client when its CA file changes.Compatibility
The trusted issuers for regular API requests can change. Users with custom endpoints or TLS inspection proxies should review their trust configuration. Explicit CA files remain supported.
The gem version is unchanged; the release version is left to the maintainers. This delegates CA management upstream and does not itself implement the pending HTTPClient mitigation in nahi/httpclient#481.
Verification
tdandfluent-plugin-tdclient initialization paths; neither references the bundled CA file.tdcurrently requirestd-client < 3;fluent-plugin-tdrequirestd-client >= 1.0.8.git diff --checkpassed.