Repository navigation
Conversation
FirstValue, LastValue, NthValue, Lead, and Lag are all registered on
the TrinoSQLCompiler, but don't declare `_traverse_internals` or
`inherit_cache`, so SQLAlchemy's SQL compilation cache (introduced in 1.4)
can't produce a cache key, falls back to recompiling from scratch every
time, and emits a warning ("Class X will not make use of SQL compilation
caching...").
Each class now gets its own _traverse_internals, extending Function's (the
nearest ancestor in their hierarchy that defines one) with an extra
traversal instruction for `ignore_nulls`.
For backwards compatibility, there's a hasattr check for
Function._traverse_internals (doesn't exist pre-1.4)
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FirstValue,LastValue,NthValue,Lead, andLag(the IGNORE NULLS-capable window functions registered onTrinoSQLCompiler), don't declare_traverse_internalsorinherit_cache, which means SQLAlchemy's SQL compilation cache (added in 1.4) can't produce a cache key, falls back to recompiling from scratch every time, and emits a warning ("Class X will not make use of SQL compilation caching...").Each class now gets its own
_traverse_internals, extendingFunction's (the nearest ancestor in their hierarchy that defines one) with an extra traversal instruction forignore_nulls.For backwards compatibility, there's a
hasattrcheck forFunction._traverse_internals(doesn't exist pre-1.4)Added two parametrized tests (across all five functions) confirming a cache key is actually produced with no warning, and that cache keys correctly distinguish both different arguments and different ignore_nulls values. Confirmed both new tests fail without the code fix.
Reproduce with (sqlalchemy >= 1.4):
Non-technical explanation
Queries using these window functions (LAG, LEAD, FIRST_VALUE, LAST_VALUE, NTH_VALUE) couldn't benefit from SQLAlchemy's statement caching, so every execution recompiled the SQL from scratch and printed a performance-warning. This fix lets SQLAlchemy cache and reuse the compiled SQL for these statements, as it already does for most others.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x ) Release notes are required, with the following suggested text: